cmd/availdevs always rebuilds
make ; make
Note that it always rebuilds. "make -d" says it's because the command changed.
This has to do with the conditional assignment of LDLIBS
all install := LDLIBS += -lxml2
(which is an unfortunate practice, given how it causes problems like this).
That was apparently done originally because we didn't have a lint lib for xml2.
No longer relevant now that we don't run lint anymore.
Updated by Gordon Ross about 2 months ago
Maybe the conditional assignments are OK if done differently. This seems to work:
diff --git a/usr/src/cmd/availdevs/Makefile b/usr/src/cmd/availdevs/Makefile index dfa150f6c9..ecfa9e0974 100644 --- a/usr/src/cmd/availdevs/Makefile +++ b/usr/src/cmd/availdevs/Makefile @@ -38,7 +38,7 @@ INCS += -I$(ADJUNCT_PROTO)/usr/include/libxml2 # LDLIBS += -lzfs_jni -lnvpair -lzfs NATIVE_LIBS += libxml2.so -all install := LDLIBS += -lxml2 +$(PROG) := LDLIBS += -lxml2 CPPFLAGS += $(INCS) -D_LARGEFILE64_SOURCE=1 -D_REENTRANT $(NOT_RELEASE_BUILD) CPPFLAGS += -DDEBUG
Updated by Electric Monk 26 days ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 5fbc1fe0da7f34cf8155bf7624c94583cc98e47c Author: Gordon Ross <email@example.com> Date: 2021-03-18T00:58:51.000Z 13526 cmd/availdevs always rebuilds Reviewed by: Richard Lowe <firstname.lastname@example.org> Reviewed by: Andy Fiddaman <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>