Project

General

Profile

Actions

Feature #13530

closed

Update nvmeadm identify to 1.4

Added by Robert Mustacchi 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

We should update the output of nvmeadm identify for both the primary namespace and controller today only knows about NVMe 1.1. We should update this to know about NVMe 1.4. This'll both help users know what's going on with their devices and help developers figure out where to continue to expand nvmeadm.

Actions #1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 1243
Actions #2

Updated by Robert Mustacchi 7 months ago

To test this I looked at the nvmeadm output from several NVMe 1.3 and 1.4 devices from folks including:

  • Micron
  • Kioxia
  • HP
  • Intel
  • Kingston
  • Samsung

For each of these I looked at the verbose identify output for both the controller and the main namespace before and after this change. The main differences that weren't just formatting were identification of the number of blocks for atomic/CAS related operations because it wasn't properly checking the feature bit in the past. Otherwise, various spot checks of data seemed to line up.

Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 8d5300d3859436fa82e7199f50011911090c65dc

commit  8d5300d3859436fa82e7199f50011911090c65dc
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-03-10T17:05:39.000Z

    13530 Update nvmeadm identify to 1.4
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF