Project

General

Profile

Bug #13561

nfs: implicit conversion from 'enum nfsstat4' to 'enum clnt_stat'

Added by Toomas Soome 21 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
nfs - NFS server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error with gcc 10:

    ../../common/fs/nfs/nfs4_subr.c: In function 'rfs4call':
    ../../common/fs/nfs/nfs4_subr.c:1586:30: error: implicit conversion from 'enum n
    fsstat4' to 'enum clnt_stat' [-Werror=enum-conversion]
     1586 |  enum clnt_stat rpc_status = NFS4_OK;
          |                              ^~~~~~~
    cc1: all warnings being treated as errors
    *** Error code 1
    dmake: Warning: Command failed for target `obj64/nfs4_subr.o'
    Current working directory /code/illumos-gate/usr/src/uts/intel/nfs

Since this is enum of RPC status codes, we should use RPC_SUCCESS here.

Testing done: build/install/boot

#1

Updated by Electric Monk 21 days ago

  • Gerrit CR set to 1271
#2

Updated by Electric Monk 18 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 8bf842e01303492318712f55e3f715097c4df992

commit  8bf842e01303492318712f55e3f715097c4df992
Author: Toomas Soome <tsoome@me.com>
Date:   2021-02-19T15:31:32.000Z

    13561 nfs: implicit conversion from 'enum nfsstat4' to 'enum clnt_stat'
    Reviewed by: Yuri Pankov <yuripv@yuripv.dev>
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF