Project

General

Profile

Actions
Copy link

Bug #13562

closed

zlogin for Solaris10 branded zones does not work after implementation of Feature #13274

Added by Klaus Ziegler 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Low
Assignee:
Klaus Ziegler
Category:
zones
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
-fstack-protector-strong zlogin
Gerrit CR:

Description

Failure message:
root@myserver:~# zlogin myzone
[Connected to zone 'myzone' pts/2]
ld.so.1: s10_brand.so.1: fatal: relocation error: file /.SUNWnative/usr/lib/s10_brand.so.1: symbol __stack_chk_guard: referenced symbol not found

[Connection to zone 'myzone' pts/2 closed]

Related issues

Related to illumos gate - Feature #13274: enable -fstack-protector-strong by default in user landClosedRobert Mustacchi

Actions
Actions
Copy link
 #1

Updated by Robert Mustacchi 3 months ago

It seems likely we need an exception for the stack protector in the S10 brand shared object. If we have a fix for this, is that something you can help test somehow?

Actions
Copy link
 #2

Updated by Klaus Ziegler 3 months ago

I have set up a new build system, and currently building the gate with the following fix:


--- usr/src/lib/brand/shared/brand/Makefile.com.orig    2021-02-18 15:05:21.509486997 +0000
+++ usr/src/lib/brand/shared/brand/Makefile.com    2021-02-18 20:43:08.915143139 +0000
@@ -55,6 +55,11 @@
 CFLAGS +=    $(CCVERBOSE)
 ASFLAGS =    -P $(ASFLAGS_$(CURTYPE)) -D_ASM -I. -I../sys

+#
+# Disable stack protection as this code might be running in an s10 context.
+#
+STACKPROTECT = none
+
 # intentional code after abort()
 SMOFF += unreachable

--- usr/src/lib/brand/solaris10/s10_brand/Makefile.com.orig    2021-02-18 15:05:21.518972721 +0000
+++ usr/src/lib/brand/solaris10/s10_brand/Makefile.com    2021-02-18 20:42:07.318692156 +0000
@@ -84,6 +84,11 @@
 DYNFLAGS +=    $(BLOCAL) $(ZNOVERSION) -Wl,-e_start
 LDLIBS +=    -lmapmalloc -lc

+#
+# Disable stack protection as we're running in an s10 context.
+#
+STACKPROTECT = none
+
 CERRWARN +=    $(CNOWARN_UNINIT)

 $(LIBS):= PICS += $(SHAREDOBJS)
Actions
Copy link
 #3

Updated by Klaus Ziegler 3 months ago

The build of the gate has been finished, the 32/64 bit s10_brand.so.1 libraries have been copied over to my production system and I'm able to use zlogin again, therefore this bug is fixed.

Actions
Copy link
 #4

Updated by Andy Fiddaman 3 months ago

  • Related to Feature #13274: enable -fstack-protector-strong by default in user land added
Actions
Copy link
 #5

Updated by Dan McDonald 2 months ago

  • Subject changed from zlogin for Solaris10 branded zones does not work after implementation of Feature #13274 to zlogin for Solaris10 branded zones does not work after implementation of Feature #13274
Actions
Copy link
 #6

Updated by Electric Monk 2 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit ba32d0fa40167766c2c4c2a83c7475bd3aed4258

commit  ba32d0fa40167766c2c4c2a83c7475bd3aed4258
Author: Klaus Ziegler <klausz@haus-gisela.de>
Date:   2021-03-02T01:34:33.000Z

    13562 zlogin for Solaris10 branded zones does not work after implementation of Feature #13274
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF