Project

General

Profile

Actions

Bug #13565

closed

umem should only have one text section

Added by Rich Lowe over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Now we don't keep the PTC implementation in a separate writable segment, we should just keep it in the regular text segment not a separate one. This will have the side effect of keeping them in the regular text section.
Some things which inspect ELF get confused if there are multiple .text sections, and it'd be nice if using them on things linked to libumem nevertheless worked.

Actions #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1275
Actions #2

Updated by Rich Lowe over 1 year ago

tested with software that got confused previously (most notably valgrind), tested that umem still worked. Tested that PTC was still being used by running under mdb and checking ::umastat per Robert's directions.

Actions #3

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 9f160f41aaee44e207fb709edec8d6493d3c4f2d

commit  9f160f41aaee44e207fb709edec8d6493d3c4f2d
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-03-05T19:32:27.000Z

    13565 umem should only have one text section
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF