Project

General

Profile

Actions

Bug #13566

closed

libm: 'fq[0]' may be used uninitialized

Added by Toomas Soome over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error with gcc 10:

    ../common/C/__rem_pio2m.c: In function '__libm__rem_pio2m':
    ../common/C/__rem_pio2m.c:329:10: error: 'fq[0]' may be used uninitialized in this function [-Werror=maybe-uni
    nitialized]
      329 |   fw = fq[0] - fw;
          |        ~~^~~
    cc1: all warnings being treated as errors
    *** Error code 1
    dmake: Warning: Command failed for target `pics/__rem_pio2m.o'
    Current working directory /code/illumos-gate/usr/src/lib/libm/amd64

Testing done: used test from netbsd libm test kit:

tsoome@beastie:/code/illumos-gate/usr/src/test/libm-tests$ ./sin_test -l
Content-Type: application/X-atf-tp; version="1" 

ident: sin_angles
descr: Test some selected angles

ident: sin_nan
descr: Test sin(NaN) == NaN

ident: sin_inf_neg
descr: Test sin(-Inf) == NaN

ident: sin_inf_pos
descr: Test sin(+Inf) == NaN

ident: sin_zero_neg
descr: Test sin(-0.0) == -0.0

ident: sin_zero_pos
descr: Test sin(+0.0) == +0.0

ident: sinf_angles
descr: Test some selected angles

ident: sinf_nan
descr: Test sinf(NaN) == NaN

ident: sinf_inf_neg
descr: Test sinf(-Inf) == NaN

ident: sinf_inf_pos
descr: Test sinf(+Inf) == NaN

ident: sinf_zero_neg
descr: Test sinf(-0.0) == -0.0

ident: sinf_zero_pos
descr: Test sinf(+0.0) == +0.0
tsoome@beastie:/code/illumos-gate/usr/src/test/libm-tests$ for i in sin_angles sin_nan sin_inf_neg sin_inf_pos sin_zero_neg sin_zero_pos sinf_angles sinf_nan sinf_inf_neg sinf_inf_pos sinf_zero_neg sinf_zero_pos; do
> ./sin_test $i
> done
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
sin_test: WARNING: Running test cases outside of kyua(1) is unsupported
sin_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)
passed
tsoome@beastie:/code/illumos-gate/usr/src/test/libm-tests$

Actions #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1274
Actions #2

Updated by Toomas Soome about 1 year ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 7c94ff60ae7c4cbdb9496a43a9d9eb85568413e3

commit  7c94ff60ae7c4cbdb9496a43a9d9eb85568413e3
Author: Toomas Soome <tsoome@me.com>
Date:   2021-05-24T17:42:31.000Z

    13566 libm: 'fq[0]' may be used uninitialized
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF