Project

General

Profile

Bug #13573

stop working around broken _msg makefiles and fix them

Added by Rich Lowe 15 days ago. Updated 10 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1280

Description

Right now we create catalog directories in usr/src/Makefile during the first step of the msg build. It seems we do this because a tiny minority of components don't have correct _msg targets that depend on $(MSGDOMAIN). We should just fix those Makefiles and make usr/src/Makefile simpler.

#1

Updated by Electric Monk 15 days ago

  • Gerrit CR set to 1280
#2

Updated by Rich Lowe 15 days ago

Tested with builds, custom targets that build the _msg target of each component after deleting $(ROOT)/catalog to make sure they do it right, diff of $(ROOT)/catalog after the first phase of the _msg build.

The only difference in that diff are timestamps, and comment removals from where I fixed mksh to do things fully properly (I felt compelled, since it was my fault in the first place).

#3

Updated by Electric Monk 10 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3a51e5c06fdc66b1c3883ded28372f6ae8e9cedb

commit  3a51e5c06fdc66b1c3883ded28372f6ae8e9cedb
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-02-26T17:39:19.000Z

    13573 stop working around broken _msg makefiles and fix them
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.dev>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF