Project

General

Profile

Actions

Bug #13574

closed

loader.efi: efifb_gop_get_edid() is broken

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

First of all, we need gop handle, not protocol to read out the EDID. Then, to simplify our life, use EFI_OPEN_PROTOCOL_GET_PROTOCOL. This allows us to save from cleanup.

Also add back fallback to EFI_EDID_DISCOVERED_PROTOCOL_GUID, even as EFI_EDID_ACTIVE_PROTOCOL_GUID should do, we never know.

Testing done: confirm with framebuffer get, we do have EDID.

Actions #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1281
Actions #2

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f38f28fdbc29b3c5020295a6c6cb1ac52e949978

commit  f38f28fdbc29b3c5020295a6c6cb1ac52e949978
Author: Toomas Soome <tsoome@me.com>
Date:   2021-03-16T18:15:13.000Z

    13574 loader.efi: efifb_gop_get_edid() is broken
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF