Project

General

Profile

Bug #13580

cpcgen frees bad buffer

Added by Rich Lowe about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

cpcgen does (with irrelevant bits elided):

  desc = strdup(...);
  desc++;
  free(desc);

it shouldn't.

#1

Updated by Electric Monk about 2 months ago

  • Gerrit CR set to 1284
#2

Updated by Rich Lowe about 1 month ago

tested under libumem, and by comparing output

#3

Updated by Electric Monk about 1 month ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 431a74760e42d5af1054ef3d5de0e389ea277476

commit  431a74760e42d5af1054ef3d5de0e389ea277476
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-03-10T19:27:22.000Z

    13580 cpcgen frees bad buffer
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF