Project

General

Profile

Actions
Copy link

Bug #13581

closed

geniconvtbl gets really confused about freeing cpp options

Added by Rich Lowe over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1285

Description

geniconvtbl keeps a list of options for the C pre-processor, but is very confused about how to free them, and ends up freeing junk.

In short, we end up freeing pointer we allocated, and not the memory we allocated, while also freeing off the end of the list.

Actions
Copy link
 #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1285
Actions
Copy link
 #2

Updated by Rich Lowe over 1 year ago

tested by building under libumem with this geniconvtbl installed, and no longer aborting
(later tested with #13588)

Actions
Copy link
 #3

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit c45618a5778581b6ec976bf7c034fd7afaa757d7

commit  c45618a5778581b6ec976bf7c034fd7afaa757d7
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-03-10T19:27:22.000Z

    13581 geniconvtbl gets really confused about freeing cpp options
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions
Copy link

Also available in: Atom PDF