Project

General

Profile

Actions
Copy link

Bug #13588

closed

want a tools geniconvtbl

Added by Rich Lowe 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1292

Description

We should move the native geniconvtbl build to usr/src/tools, and use it in lib/iconv_modules too.

While we're here, we could make the Makefile considerably less baroque

Actions
Copy link
 #1

Updated by Electric Monk 3 months ago

  • Gerrit CR set to 1292
Actions
Copy link
 #2

Updated by Rich Lowe 3 months ago

Tested by building with the #13581 fix and seeing that libumem no longer aborts on the bad free.

Tested the makefile changes by build and it working and comparison of the message catalog (which gets extra messages that seem like they were missing before, since some are explicitly created in other bits of makefile)

Actions
Copy link
 #3

Updated by Rich Lowe 3 months ago

also tested with a full wsdiff, which founds some issues otherwise missed because of the state of the makefile.

Differences are now the message catalog (getting better, as above), and geniconvtbl.so being built with the regular library set of ld flags and gaining direct binding, etc, etc.

Actions
Copy link
 #4

Updated by Electric Monk 2 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit b8767451d156f585534afac0bf22721810d0dc63

commit  b8767451d156f585534afac0bf22721810d0dc63
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-03-10T19:27:22.000Z

    13588 want a tools geniconvtbl
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions
Copy link

Also available in: Atom PDF