Project

General

Profile

Actions
Copy link

Bug #13591

closed

bnxe: implicit conversion from 'enum <anonymous>' to 'lm_status_t'

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1298

Description

Build errors with gcc 10:

    ../../common/io/bnxe/bnxe_hw.c: In function 'BnxeRssDisable':
    ../../common/io/bnxe/bnxe_hw.c:149:47: error: implicit conversion from 'enum <anonymous>' to 'lm_s
    tatus_t' [-Werror=enum-conversion]
      149 |     return (rc == LM_STATUS_SUCCESS) ? B_TRUE : B_FALSE;
          |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
    cc1: all warnings being treated as errors
    *** Error code 1
    dmake: Warning: Command failed for target `obj64/bnxe_hw.o'
    Current working directory /code/illumos-gate/usr/src/uts/intel/bnxe

Testing done: build/install/boot. The return value from BnxeRssDisable() is never checked in current code.

Actions
Copy link
 #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1298
Actions
Copy link
 #2

Updated by Toomas Soome over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 8993acd7cf0075cbfaf6df95d292f897079b5618

commit  8993acd7cf0075cbfaf6df95d292f897079b5618
Author: Toomas Soome <tsoome@me.com>
Date:   2021-03-09T15:59:32.000Z

    13591 bnxe: implicit conversion from 'enum <anonymous>' to 'lm_status_t'
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF