Actions
Feature #13602
closedcpuset funcs could be more const
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:
Description
The cpuset_or
, cpuset_xor
, and cpuset_and
functions could specify that their respective src
arguments are const, making it clear to callers which is source and destination without having to look at the code itself.
Related issues
Updated by Patrick Mooney almost 3 years ago
- Related to Feature #10932: want _MACHDEP-free cpuset_t access added
Updated by Patrick Mooney over 2 years ago
Considering the nature of the change, I tested it with wsdiff(1)
against a vanilla build.
Here are the results:
Old proto area: /ws/builds/il13602/proto.orig/ New proto area: /ws/builds/il13602/proto/ Results file: wsdiff.out ERROR: diff_ctf: Could not find genunix. CTF diffs will be less useful. usr/sbin/iasl NOTE: ELF .rodata difference detected. 42975,42978c42975,42978 < 1305120 o n : % s \n \0 m a s t e r - 0 < 203a6e6f 000a7325 7473616d 302d7265 < 1305140 - g 0 f 5 6 e 1 4 5 e 1 \0 \t \n < 6630672d 31653635 31653534 0a092000 --- > 1305120 o n : % s \n \0 i 1 3 6 0 2 - 0 > 203a6e6f 000a7325 36333169 302d3230 > 1305140 - g 7 6 0 e 2 4 6 e 6 e \0 \t \n > 3637672d 34326530 65366536 0a092000 usr/sbin/acpixtract NOTE: ELF .rodata difference detected. 302,305c302,305 < 0004600 % s \n \0 m a s t e r - 0 - g 0 f < 000a7325 7473616d 302d7265 6630672d < 0004620 5 6 e 1 4 5 e 1 \0 B u i l d v < 31653635 31653534 69754200 7620646c --- > 0004600 % s \n \0 i 1 3 6 0 2 - 0 - g 7 6 > 000a7325 36333169 302d3230 3637672d > 0004620 0 e 2 4 6 e 6 e \0 B u i l d v > 34326530 65366536 69754200 7620646c usr/sbin/acpidump NOTE: ELF .rodata difference detected. 428,431c428,431 < 0006660 % 8 . 8 X \n % s \n \n \0 m a s t < 2e382520 250a5838 000a0a73 7473616d < 0006700 e r - 0 - g 0 f 5 6 e 1 4 5 e 1 < 302d7265 6630672d 31653635 31653534 --- > 0006660 % 8 . 8 X \n % s \n \n \0 i 1 3 6 > 2e382520 250a5838 000a0a73 36333169 > 0006700 0 2 - 0 - g 7 6 0 e 2 4 6 e 6 e > 302d3230 3637672d 34326530 65366536 usr/include/sys/cpuvar.h NOTE: ASCII difference detected. 26d25 < * Copyright 2018 Joyent, Inc. 28a28 > * Copyright 2021 Oxide Computer Company 439,441c439,441 < extern void cpuset_or(cpuset_t *, cpuset_t *); < extern void cpuset_xor(cpuset_t *, cpuset_t *); < extern void cpuset_and(cpuset_t *, cpuset_t *); --- > extern void cpuset_or(cpuset_t *, const cpuset_t *); > extern void cpuset_xor(cpuset_t *, const cpuset_t *); > extern void cpuset_and(cpuset_t *, const cpuset_t *); etc/versions/build NOTE: ASCII difference detected. 1c1 < heads/master-0-g0f56e145e1 --- > heads/i13602-0-g760e246e6e-dirty etc/motd NOTE: ASCII difference detected. 1,2c1,2 < The illumos Project master-0-g0f56e145e1 Mar. 04, 2021 < illumos development build: pmooney 2021-Mar-04 [il13602] --- > The illumos Project i13602-0-g760e246e6e Mar. 05, 2021 > illumos development build: pmooney 2021-Mar-05 [il13602] platform/i86pc/kernel/amd64/unix NOTE: ELF .data difference detected. 10372,10375c10372,10375 < 0706160 \0 \0 \0 \0 \0 \0 \0 m a s t e r - 0 - < 00000000 6d000000 65747361 2d302d72 < 0706200 g 0 f 5 6 e 1 4 5 e 1 \0 \0 \0 \0 \0 < 35663067 34316536 00316535 00000000 --- > 0706160 \0 \0 \0 \0 \0 \0 \0 i 1 3 6 0 2 - 0 - > 00000000 69000000 30363331 2d302d32 > 0706200 g 7 6 0 e 2 4 6 e 6 e \0 \0 \0 \0 \0 > 30363767 36343265 00653665 00000000 platform/i86xpv/kernel/amd64/unix NOTE: ELF .data difference detected. 8628,8631c8628,8631 < 1105120 \0 \0 \0 \0 \0 \0 \0 \0 \0 \0 \0 m a s t e < 00000000 00000000 6d000000 65747361 < 1105140 r - 0 - g 0 f 5 6 e 1 4 5 e 1 \0 < 2d302d72 35663067 34316536 00316535 --- > 1105120 \0 \0 \0 \0 \0 \0 \0 \0 \0 \0 \0 i 1 3 6 0 > 00000000 00000000 69000000 30363331 > 1105140 2 - 0 - g 7 6 0 e 2 4 6 e 6 e \0 > 2d302d32 30363767 36343265 00653665
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 5ed99ae722c542671009b80e3fb34623a2ee0a73
commit 5ed99ae722c542671009b80e3fb34623a2ee0a73 Author: Patrick Mooney <pmooney@pfmooney.com> Date: 2021-03-05T17:29:15.000Z 13602 cpuset funcs could be more const Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>
Actions