Project

General

Profile

Actions
Copy link

Bug #13609

closed

i86xpv needs to be more careful with ao_gendisp

Added by Rich Lowe over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1313

Description

i86xpv symlinks ao_gendisp from i86pc, but doesn't delete it first or use -f, so if a full (debug and non-debug) build rebuilds it for any reason the second build will fail.

Related issues

Related to illumos gate - Bug #3196: ao_gendisp use by make is raceyResolvedMarcel Telka2012-09-14

Actions
Actions
Copy link
 #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1313
Actions
Copy link
 #2

Updated by Rich Lowe over 1 year ago

  • Related to Bug #3196: ao_gendisp use by make is racey added
Actions
Copy link
 #3

Updated by Rich Lowe over 1 year ago

Tested with the problematic build config, and also isolated builds in i86xpv

Actions
Copy link
 #4

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 24ffd7b4991aba1983bd17ddf22f48fddd796956

commit  24ffd7b4991aba1983bd17ddf22f48fddd796956
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-03-08T17:50:18.000Z

    13609 i86xpv needs to be more careful with ao_gendisp
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF