Project

General

Profile

Actions

Bug #13613

closed

ipkg platform.xml missing /dev/signalfd

Added by Jason King 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
zones
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

When #6342 upstreamed signalfd support, it unfortunately neglected to include the /dev/signalfd as a part of the devices provided to a zone, preventing signalfd(3C) from working in an ipkg zone. We should add it, e.g.:

diff --git a/usr/src/lib/brand/ipkg/zone/platform.xml b/usr/src/lib/brand/ipkg/zone/platform.xml
index 4075fe10d2..df5a8b1d11 100644
--- a/usr/src/lib/brand/ipkg/zone/platform.xml
+++ b/usr/src/lib/brand/ipkg/zone/platform.xml
@@ -76,6 +76,7 @@
        <device match="rlofi" />
        <device match="rmt" />
        <device match="sad/user" />
+       <device match="signalfd" />
        <device match="smbsrv" />
        <device match="svvslo0" />
        <device match="svvslo1" />
Actions #1

Updated by Electric Monk 9 months ago

  • Gerrit CR set to 1320
Actions #2

Updated by Jason King 9 months ago

  • Gerrit CR deleted (1320)

For affected installs, an interim workaround is to run zonecfg -z <zone> and add the following:

add device
set match=signalfd
end

and reboot the zone.

At least some builds of Postgresql attempt to use signalfd, so this bug may impact people attempting to use Postgresql in a zone.

Actions #3

Updated by Jason King 9 months ago

  • Gerrit CR set to 1320
Actions #4

Updated by Jason King 9 months ago

To test, I created a simple test zone, booted it and verified /dev/signalfd was missing.

I then built a PI w/ the change, booted it, and created a zone again and verified that /dev/signalfd was present.

Unfortunately, it does appear (currently) pre-existing zones will not get the device after an upgrade without re-installing or explicitly adding it to the zonecfg (as described in the above workaround).

Actions #5

Updated by Electric Monk 9 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 19df86dc540ec91584176ab69b765edae4562731

commit  19df86dc540ec91584176ab69b765edae4562731
Author: Jason King <jason.king@joyent.com>
Date:   2021-03-09T20:09:27.000Z

    13613 ipkg platform.xml missing /dev/signalfd
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF