Project

General

Profile

Actions
Copy link

Bug #13632

closed

smntemp doesn't need smntemp alias

Added by Robert Mustacchi 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
packaging
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1332

Description

When booting a system with the smntemp driver installed, you'll see a warning that says:

WARNING: Driver alias "smntemp" conflicts with an existing driver name or alias.

The issue here is that the manifest file has an entry that looks like: driver name=smntemp alias=smntemp. The main reason that this warning is being emitted by the /etc/driver_aliases code is that drivers effectively have an entry for their own name (which one can easily see with other children of nexus drivers). The simple thing is to remove the alias entry. Testing this makes it easy to see that everything still works. e.g.

$ pfexec /usr/lib/fm/fmd/fmtopo -V *sensor=temp*
TIME                 UUID
Mar 14 12:25:15 398ef52d-fbf5-efd8-b2fc-eab2b71ec57f

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=0?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=0?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=1?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=1?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=2?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=2?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=3?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=3?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=4?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=4?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=5?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=5?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=6?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=6?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=7?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=7?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=8?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=8?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=9?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=9?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=10?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=10?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=11?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=11?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=12?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=12?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=13?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=13?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=14?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=14?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000

hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=15?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0/core=15?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    38.500000
<pre>

That comes from a system with the AMD Rome system that uses the @smntemp@ driver to get temperature sensors.
Actions
Copy link
 #1

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 1332
Actions
Copy link
 #2

Updated by Rich Lowe 2 months ago

  • Subject changed from smntemp doesn't need smentemp alias to smntemp doesn't need smntemp alias
Actions
Copy link
 #3

Updated by Electric Monk about 2 months ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 8781de92560745751daa24953330574a84de46e6

commit  8781de92560745751daa24953330574a84de46e6
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-03-16T15:53:15.000Z

    13632 smntemp doesn't need smntemp alias
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Yuri Pankov <yuripv@yuripv.dev>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF