Project

General

Profile

Actions

Bug #13634

closed

fstat(2) does not use flag

Added by Marcel Telka 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
manpage - manual pages
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The stat(2) man page contains this:

       st_mode
                     The mode of the file as described for the mknod()
                     function. In addition to the modes described on the
                     mknod(2) manual page, the mode of a file can also be
                     S_IFSOCK if the file is a socket, S_IFDOOR if the file is
                     a door, S_IFPORT if the file is an event port, or S_IFLNK
                     if the file is a symbolic link. S_IFLNK can be returned
                     either by lstat() or by fstat() when the
                     AT_SYMLINK_NOFOLLOW flag is set.

Apparently, fstat() should be changed to fstatat() there.


Related issues

Related to illumos gate - Bug #13594: Valid flag for fchownat(2) is AT_SYMLINK_NOFOLLOW, not SYMLNKClosedMarcel Telka

Actions
Actions #1

Updated by Marcel Telka 9 months ago

  • Related to Bug #13594: Valid flag for fchownat(2) is AT_SYMLINK_NOFOLLOW, not SYMLNK added
Actions #2

Updated by Marcel Telka 9 months ago

Review: https://www.illumos.org/rb/r/2583/

Testing

I reviewed the updated man page using the following command:

MANPATH=usr/src/man man fstatat

Nightly passed.

Actions #3

Updated by Electric Monk 9 months ago

  • Gerrit CR set to 1342
Actions #4

Updated by Marcel Telka 9 months ago

  • Status changed from In Progress to Pending RTI
Actions #5

Updated by Electric Monk 9 months ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit 9f79d3c392a4c8e07013da154cd979c21f168c74

commit  9f79d3c392a4c8e07013da154cd979c21f168c74
Author: Marcel Telka <marcel@telka.sk>
Date:   2021-03-19T16:50:07.000Z

    13634 fstat(2) does not use flag
    Reviewed by: Yuri Pankov <yuripv@yuripv.dev>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF