Project

General

Profile

Actions

Bug #13656

closed

pbchk: filter HTTP 401 responses

Added by Toomas Soome about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Sometimes we do get following error from pbchk:

tsoome@beastie:/code/illumos-gate$ git pbchk 
url http://illumos.org/issues/744.xml
url http://illumos.org/issues/776.xml
Traceback (most recent call last):
  File "/opt/onbld/bin/git-pbchk", line 483, in <module>
    main(os.path.basename(sys.argv[0]), sys.argv[1:])
  File "/opt/onbld/bin/git-pbchk", line 475, in main
    pbchk(git_root(), parent_branch, None)
  File "/opt/onbld/bin/git-pbchk", line 442, in pbchk
    run_checks(root, parent, cmds, scmds)
  File "/opt/onbld/bin/git-pbchk", line 396, in run_checks
    output=s)
  File "/opt/onbld/bin/git-pbchk", line 227, in comchk
    output=output)
  File "/opt/onbld/bin/../lib/python3.5/onbld/Checks/Comments.py", line 127, in comchk
    results = bugdb.lookup(list(bugs.keys()))
  File "/opt/onbld/bin/../lib/python3.5/onbld/Checks/DbLookups.py", line 122, in lookup
    results[str(cr)] = self.__illbug(cr)
  File "/opt/onbld/bin/../lib/python3.5/onbld/Checks/DbLookups.py", line 89, in __illbug
    data = urlopen(req)
  File "/usr/lib/python3.5/urllib/request.py", line 163, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.5/urllib/request.py", line 472, in open
    response = meth(req, response)
  File "/usr/lib/python3.5/urllib/request.py", line 582, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.5/urllib/request.py", line 504, in error
    result = self._call_chain(*args)
  File "/usr/lib/python3.5/urllib/request.py", line 444, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.5/urllib/request.py", line 696, in http_error_302
    return self.parent.open(new, timeout=req.timeout)
  File "/usr/lib/python3.5/urllib/request.py", line 472, in open
    response = meth(req, response)
  File "/usr/lib/python3.5/urllib/request.py", line 582, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.5/urllib/request.py", line 504, in error
    result = self._call_chain(*args)
  File "/usr/lib/python3.5/urllib/request.py", line 444, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.5/urllib/request.py", line 696, in http_error_302
    return self.parent.open(new, timeout=req.timeout)
  File "/usr/lib/python3.5/urllib/request.py", line 472, in open
    response = meth(req, response)
  File "/usr/lib/python3.5/urllib/request.py", line 582, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.5/urllib/request.py", line 510, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.5/urllib/request.py", line 444, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.5/urllib/request.py", line 590, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 401: Unauthorized
tsoome@beastie:/code/illumos-gate$

Add check for 401 and the same pbcheck session will be:

tsoome@beastie:/code/illumos-gate$ git pbchk 
Comments:
WARNING: Blank line(s) in comments
These comments are not valid bugs:
  xargs.c: In function 'echoargs':
  xargs.c:776:11: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
  |  ~~~~~~~~~^~~
  xargs.c:744:8: note: at offset 2048 to object 'reply' with size 2048 declared here
  |        ^~~~~
  cc1: all warnings being treated as errors
  *** Error code 1
  dmake: Fatal error: Command failed for target `xargs.o'
  Current working directory /code/illumos-gate/usr/src/cmd/xargs
  Change-Id: I1d0097471281aacb252779c79625e364d044fc8c
These bugs were not found in the databases:
  776
These bug synopses don't match the database entries:
Synopsis of 744 is wrong:
  should be: 'Intel D525MWV and ehci driver'
         is: '|  char  reply[LINE_MAX];'

Copyrights:
usr/src/cmd/xargs/xargs.c: no copyright claim for current year found

tsoome@beastie:/code/illumos-gate$

Actions #1

Updated by Electric Monk about 1 year ago

  • Gerrit CR set to 1359
Actions #2

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit ff02f816914596a5b08ed3ef117ba39db27d217f

commit  ff02f816914596a5b08ed3ef117ba39db27d217f
Author: Toomas Soome <tsoome@me.com>
Date:   2021-03-25T15:34:42.000Z

    13656 pbchk: filter HTTP 401 responses
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF