pkg lint should not run if we are not building packages
pkg lint seems to run no matter if we build packages ('p' in NIGHTLY_OPTIONS) or not, it shouldn't as it's going to fail anyway:
==== Linting packages ==== Lint engine setup... Error: Unable to create reference image: No lint image or manifests provided. *** Error code 2 The following command caused the error: for r in redist; do \ pkglint \ -f packages.i386/pkglintrc \ -c /home/yuripv/ws/clrep/packages/i386/nightly/lint.image \ -r /home/yuripv/ws/clrep/packages/i386/nightly/repo.$r \ `/usr/bin/find packages.i386 -name \*.fin \! -size 0c -print`; \ done
Here I'm skipping pkg build to speed up nightly.
Updated by Matt Fiddaman about 1 year ago
To test my change, I ran nightly without -p and without -L before the change, and it attempted pkglint and failed. Then I ran it again with the change applied, and it did not. I also checked that all other combinations of -p and -L worked as expected.
Updated by Electric Monk about 1 year ago
- Status changed from Pending RTI to Closed
- % Done changed from 0 to 100
commit 9cc2e6ac8556ab1cd4646da3f3a7dea34a98e0f2 Author: Matt Fiddaman <firstname.lastname@example.org> Date: 2021-05-21T19:26:03.000Z 13667 pkg lint should not run if we are not building packages Reviewed by: Gordon Ross <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>