Project

General

Profile

Actions

Bug #13667

closed

pkg lint should not run if we are not building packages

Added by Yuri Pankov 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

pkg lint seems to run no matter if we build packages ('p' in NIGHTLY_OPTIONS) or not, it shouldn't as it's going to fail anyway:

==== Linting packages ====

Lint engine setup...
Error: Unable to create reference image: No lint image or manifests provided.
*** Error code 2
The following command caused the error:
for r in redist; do \
        pkglint \
            -f packages.i386/pkglintrc \
            -c /home/yuripv/ws/clrep/packages/i386/nightly/lint.image \
            -r /home/yuripv/ws/clrep/packages/i386/nightly/repo.$r \
            `/usr/bin/find packages.i386 -name \*.fin \! -size 0c -print`; \
done

Here I'm skipping pkg build to speed up nightly.


Related issues

Related to illumos gate - Feature #12708: Packages could be lintedClosedAndy Fiddaman

Actions
Actions #1

Updated by Matt Fiddaman 7 months ago

Actions #2

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 1495
Actions #3

Updated by Matt Fiddaman 7 months ago

  • Assignee set to Matt Fiddaman
Actions #4

Updated by Matt Fiddaman 7 months ago

To test my change, I ran nightly without -p and without -L before the change, and it attempted pkglint and failed. Then I ran it again with the change applied, and it did not. I also checked that all other combinations of -p and -L worked as expected.

Actions #5

Updated by Matt Fiddaman 7 months ago

  • Status changed from New to Pending RTI
Actions #6

Updated by Electric Monk 7 months ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit 9cc2e6ac8556ab1cd4646da3f3a7dea34a98e0f2

commit  9cc2e6ac8556ab1cd4646da3f3a7dea34a98e0f2
Author: Matt Fiddaman <illumos@m.fiddaman.uk>
Date:   2021-05-21T19:26:03.000Z

    13667 pkg lint should not run if we are not building packages
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF