Project

General

Profile

Actions

Feature #13688

closed

Want support for AMD Zen 3 Milan CPC Events

Added by Robert Mustacchi 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

As there's now public documentation on AMD's website about Zen 3 Milan CPU performance counters, we should update the pmc data. There are some differences that I've noticed between Milan and Vermeer so I haven't gone through and enabled Ryzen related Zen 3 parts as of this time. Hopefully AMD publishes public docs soon.

Actions #1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 1463
Actions #2

Updated by Robert Mustacchi 7 months ago

To test this I used a Milan system and looked at a couple things:

1. Made sure that we saw expected stats in cpustat -h
2. Bound a thread to a specific cpu and did a shell while :; do :; done loop. I then enabled the PAPI total cycles counter and made sure that the value for the CPU in question tracked the approximate frequency and was for the right CPU!

I then went back to a Rome system and verified that the counters seen via cpustat -h hadn't changed.

Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from New to Closed
  • % Done changed from 70 to 100

git commit 281939df320dc275543124ebb96b5a9415c503be

commit  281939df320dc275543124ebb96b5a9415c503be
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-05-06T19:18:03.000Z

    13688 Want support for AMD Zen 3 Milan CPC Events
    Reviewed by: Sean Klein <sean@oxidecomputer.com>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF