Project

General

Profile

Actions
Copy link

Bug #13713

closed

vm_unmap_mmio() should return non zero on error

Added by Andy Fiddaman over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Andy Fiddaman
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1412
External Bug:

Description

See #13712 for a more detailed description. When vm_map_remove() fails, the error code is not propagated to the caller.

 15  81866             vm_map_remove:return                 2
 15  82845             vm_unmap_mmio:return                 0
 15  81162            ppt_unmap_mmio:return                 0

Related issues

Related to illumos gate - Bug #13712: bhyve allows vmspace mapping inside existing rangeClosedAndy Fiddaman

Actions
Actions
Copy link
 #1

Updated by Andy Fiddaman over 2 years ago

  • Related to Bug #13712: bhyve allows vmspace mapping inside existing range added
Actions
Copy link
 #2

Updated by Electric Monk over 2 years ago

  • Gerrit CR set to 1412
Actions
Copy link
 #3

Updated by Andy Fiddaman over 2 years ago

This has been tested applied on top of #13712, booting a variety of VMs with and without pass-through devices. No problems encountered.

It has also been more extensively tested in conjunction with #13674 - see the notes in #13712 for details.

Actions
Copy link
 #4

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 2282d3b00bd23a5df4dfea0edd5ae737693bd4b7

commit  2282d3b00bd23a5df4dfea0edd5ae737693bd4b7
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2021-04-19T09:09:36.000Z

    13713 vm_unmap_mmio() should return non zero on error
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Jorge Schrauwen <sjorge@blackdot.be>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF