Project

General

Profile

Actions

Bug #13725

closed

ms: cast between incompatible function types

Added by Toomas Soome 22 days ago. Updated 4 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors on SPARC:

    ../../sun/io/ms.c:214:2: error: cast between incompatible function types from 'void (*)(queue_t *, mblk_t *)' {aka 'void (*)(struct queue *, struct msgb *)'} to 'int (*)()' [-Werror=cast-function-type]
      214 |  (int (*)())msrput,
          |  ^
    ../../sun/io/ms.c:215:2: error: cast between incompatible function types from 'void (*)(queue_t *)' {aka 'void (*)(struct queue *)'} to 'int (*)()' [-Werror=cast-function-type]
      215 |  (int (*)())msrserv,
          |  ^
    ../../sun/io/ms.c:232:2: error: cast between incompatible function types from 'void (*)(queue_t *, mblk_t *)' {aka 'void (*)(struct queue *, struct msgb *)'} to 'int (*)()' [-Werror=cast-function-type]
      232 |  (int (*)())mswput,
          |  ^
    cc1: all warnings being treated as errors

Testing done: build/install/boot, however, my host has no mouse...

Actions #1

Updated by Electric Monk 22 days ago

  • Gerrit CR set to 1422
Actions #2

Updated by Toomas Soome 4 days ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 4 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 166fc0161da8f2aef0ff36cc5241a32f8f0cf3bc

commit  166fc0161da8f2aef0ff36cc5241a32f8f0cf3bc
Author: Toomas Soome <tsoome@me.com>
Date:   2021-05-03T20:53:45.000Z

    13725 ms: cast between incompatible function types
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF