Project

General

Profile

Actions

Bug #13762

closed

stop passing MFLAGS to make(1)

Added by Rich Lowe 9 days ago. Updated 3 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

make(1) handles inheriting command line flags itself. If we pass MFLAGS to make, options that are sensitive to the numbers of times they're specified (most specifically -d) will get doubled.
In this case of -d, this will flood nightly.log with information that was likely unwanted.

Actions #1

Updated by Electric Monk 9 days ago

  • Gerrit CR set to 1451
Actions #2

Updated by Rich Lowe 9 days ago

wsdiff clean

Actions #3

Updated by Electric Monk 3 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit f96a0cef040313f6281fbc014a0b63d5c5cc760f

commit  f96a0cef040313f6281fbc014a0b63d5c5cc760f
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-05-04T18:46:34.000Z

    13762 stop passing MFLAGS to make(1)
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF