Project

General

Profile

Actions
Copy link

Feature #13776

closed

ship demangle-sys.h

Added by Joshua M. Clulow about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Joshua M. Clulow
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1468
External Bug:

Description

Though libdemangle-sys is a private interface, we ship a compilation symlink and we should ship the header as well. We currently ship many other private headers, like libzfs.h, so it seems fine to ship this one too.

Note: OmniOS already ship this in their distribution; see https://github.com/omniosorg/illumos-omnios/pull/650

Actions
Copy link
 #1

Updated by Andy Fiddaman about 2 years ago

Note: OmniOS already ship this in their distribution

Yes, and still use it for openjdk8, although we did switch to __cxa_demangle() for openjdk11

Actions
Copy link
 #2

Updated by Electric Monk about 2 years ago

  • Gerrit CR set to 1468
Actions
Copy link
 #3

Updated by Joshua M. Clulow about 2 years ago

Testing Notes

Built with updated package, checked repo with pkgrepo contents. Updated with onu and confirmed that /usr/include/demangle-sys.h now exists.

Actions
Copy link
 #4

Updated by Electric Monk almost 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3b3c8f601c5530d4928a71e238c573c623491c34

commit  3b3c8f601c5530d4928a71e238c573c623491c34
Author: Joshua M. Clulow <josh@sysmgr.org>
Date:   2021-06-27T06:31:12.000Z

    13776 ship demangle-sys.h
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF