Project

General

Profile

Actions
Copy link

Bug #13791

closed

loader: gfx_fb_drawrect should use GfxFbBltVideoFill

Added by Toomas Soome over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1478
External Bug:

Description

The gfx_fb_drawrect() is drawing rectangle by pixels, this can be very slow on some systems. Use Blt() video fill primitive instead.

Tested by Will Brokenbourghm, who was experiencing the problem. BIOS version does work as expected too, tested by myself.

Related issues

Related to illumos gate - Bug #13774: [OpenIndiana Hipster 2021.04] Slow then unusable video after startup menu on 2012 Mac miniNew

Actions
Actions
Copy link
 #1

Updated by Toomas Soome over 2 years ago

  • Related to Bug #13774: [OpenIndiana Hipster 2021.04] Slow then unusable video after startup menu on 2012 Mac mini added
Actions
Copy link
 #2

Updated by Electric Monk over 2 years ago

  • Gerrit CR set to 1478
Actions
Copy link
 #3

Updated by Toomas Soome over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d50863a3386bcb8b803fae99c4a1ef2fb668b618

commit  d50863a3386bcb8b803fae99c4a1ef2fb668b618
Author: Toomas Soome <tsoome@me.com>
Date:   2021-05-19T19:03:18.000Z

    13791 loader: gfx_fb_drawrect should use GfxFbBltVideoFill
    Reviewed by: Yuri Pankov <yuripv@yuripv.dev>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF