Project

General

Profile

Actions

Bug #13817

open

scsa2usb quirks list does not correctly use revision field

Added by Joshua M. Clulow 25 days ago. Updated 25 days ago.

Status:
New
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The USB mass storage driver (scsa2usb) handles device-specific quirks of implementation with a table of IDs. This table includes three columns for filtering purposes:

        uint16_t        idVendor;       /* vendor ID                    */
        uint16_t        idProduct;      /* product ID                   */
        uint16_t        bcdDevice;      /* device release number in bcd */

A wildcard value (the macro X) may be specified for either idProduct or bcdDevice, which would match any value.

Unfortunately, the bcdDevice column of this table is entirely ignored at present. One or two devices have correctly specified the wildcard X for the device revision, but most entries specify 0. It is almost certainly impossible to go back now and divine what value is correct for all of our existing quirks entries, so we must instead change every entry to a wildcard match as part of fixing this logic error.

While we're there, we'll clean up the code and the comments a bit.

Actions #1

Updated by Electric Monk 25 days ago

  • Gerrit CR set to 1505
Actions

Also available in: Atom PDF