scsa2usb quirks list does not correctly use revision field
The USB mass storage driver (
scsa2usb) handles device-specific quirks of implementation with a table of IDs. This table includes three columns for filtering purposes:
uint16_t idVendor; /* vendor ID */ uint16_t idProduct; /* product ID */ uint16_t bcdDevice; /* device release number in bcd */
A wildcard value (the macro
X) may be specified for either
bcdDevice, which would match any value.
bcdDevice column of this table is entirely ignored at present. One or two devices have correctly specified the wildcard
X for the device revision, but most entries specify
0. It is almost certainly impossible to go back now and divine what value is correct for all of our existing quirks entries, so we must instead change every entry to a wildcard match as part of fixing this logic error.
While we're there, we'll clean up the code and the comments a bit.