Project

General

Profile

Actions
Copy link

Bug #13852

closed

smbstat -r dumps core

Added by Gordon Ross about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Gordon Ross
Category:
cifs - CIFS server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1532
External Bug:

Description

root@romulus:/var/cores# smbstat -r
Segmentation Fault (core dumped)

Actions
Copy link
 #1

Updated by Gordon Ross about 2 years ago

  • Status changed from New to In Progress

smbstat_srv_process_requests() is using the wrong values to index the arrays of per-request stats.

Actions
Copy link
 #2

Updated by Electric Monk about 2 years ago

  • Gerrit CR set to 1532
Actions
Copy link
 #3

Updated by Gordon Ross almost 2 years ago

Testing:

Run smbstat -r
no more segv

Actions
Copy link
 #4

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 5015ecc336998f9971d6310c6faa7e992f95cc4b

commit  5015ecc336998f9971d6310c6faa7e992f95cc4b
Author: Gordon Ross <gordon.ross@tintri.com>
Date:   2021-06-07T22:03:25.000Z

    13852 smbstat -r dumps core
    Reviewed by: Evan Layton <elayton@tintri.com>
    Reviewed by: Joyce McIntosh <jmcintosh@tintri.com>
    Reviewed by: Matt Barden <mbarden@tintri.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF