Project

General

Profile

Actions

Bug #13884

closed

dis(1) should pick stable names for symbols

Added by Rich Lowe 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

At present, dis(1) will name aliased non-weak symbols semi-randomly. We should use a stable sort for the symtab.

Longer term, we should use the symsort sections for this where they exist (and cause them to exist where not).

Actions #1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 1552
Actions #2

Updated by Rich Lowe 7 months ago

testing:
verified that we picked consistent names for symbols in cases where we had not previously, and that text diffs reported by wsdiff
no longer ballooned due to differences in symbol name choice.

Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 7781236b33d51a2eb1e29bf336bdba8ddfcfff6e

commit  7781236b33d51a2eb1e29bf336bdba8ddfcfff6e
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-07-05T18:47:41.000Z

    13884 dis(1) should pick stable names for symbols
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF