Project

General

Profile

Actions
Copy link

Bug #13889

closed

ctfdump -c should sort output stably

Added by Rich Lowe almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1562
External Bug:

Description

Right now, ctfdump -c only sorts by name, we should include return types arity and parameter types so that the sort is stable.

Actions
Copy link
 #1

Updated by Rich Lowe almost 2 years ago

testing:

for elt in $(awk '/^OBJECT/ { print $5}' usr/src/ELF-data.i386/object_list); do 
        $(git proto -d)/bin/ctfdump -c $(git proto -d)/$elt >/dev/null |& grep -v 'does not contain'; 
done

and also verifying that sort results were stable in the cases where for me they were not previously.

Actions
Copy link
 #2

Updated by Electric Monk almost 2 years ago

  • Gerrit CR set to 1562
Actions
Copy link
 #3

Updated by Electric Monk almost 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 88e8a81ba29ce242b8e7eade29af1f3d301ac525

commit  88e8a81ba29ce242b8e7eade29af1f3d301ac525
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-07-05T18:47:41.000Z

    13889 ctfdump -c should sort output stably
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF