zfs holds is quadratic
zfs holds calls zfs_for_each for each argument it is given which it turn iterates over the complete set of arguments. At first glance its use of zfs_for_each seems unnecessary but it must use it to properly support recursive lookups. The fix is to only pass only one argument at a time to zfs_for_each.
Updated by Electric Monk 7 months ago
- Status changed from In Progress to Closed
commit 1e9e241fbdc7ae75a7b37c1e7afc8c96d2f43e1e Author: Andrew Stormont <firstname.lastname@example.org> Date: 2021-07-04T10:13:40.000Z 13905 zfs holds is quadratic Reviewed by: Alexander Stetsenko <email@example.com> Reviewed by: Toomas Soome <firstname.lastname@example.org> Reviewed by: Vitaliy Gusev <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>