Project

General

Profile

Actions
Copy link

Bug #13906

closed

zfs holds wrongly says there are no datasets available

Added by Andrew Stormont almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Andrew Stormont
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1571
External Bug:

Description

If none of the arguments passed to zfs holds exist it will wrongly complain that there are "no datasets available":

$ zfs holds -H nonExistentPool/nonExistentDataset@nonExistentSnapshot
cannot open 'nonExistentPool/nonExistentDataset@nonExistentSnapshot': dataset does not exist
no datasets available

I believe this message was copied from the zfs list code by mistake and should be removed.

Actions
Copy link
 #1

Updated by Electric Monk almost 2 years ago

  • Gerrit CR set to 1571
Actions
Copy link
 #2

Updated by Andrew Stormont almost 2 years ago

I have a fix out for review here: https://code.illumos.org/c/illumos-gate/+/1571

Testing: I verified that the output of the zfs holds command no longer includes "no datasets available" when passed snapshots which don't exist.

Actions
Copy link
 #3

Updated by Andrew Stormont almost 2 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Andrew Stormont almost 2 years ago

Same command with the fix applied:

$ zfs holds -H nonExistentPool/nonExistentDataset@nonExistentSnapshot
cannot open 'nonExistentPool/nonExistentDataset@nonExistentSnapshot': dataset does not exist
Actions
Copy link
 #5

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed

git commit cfcb628093a526b143a37c1a2f112f2c7591ed70

commit  cfcb628093a526b143a37c1a2f112f2c7591ed70
Author: Andrew Stormont <astormont@racktopsystems.com>
Date:   2021-07-08T16:03:01.000Z

    13906 zfs holds wrongly says there are no datasets available
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF