Project

General

Profile

Actions

Bug #13930

closed

Build fails with modern NSS

Added by Andrew Stormont 3 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The NSS header files conflict with some of the header files included in /usr/include/security.

Actions #1

Updated by Electric Monk 3 months ago

  • Gerrit CR set to 1591
Actions #2

Updated by Andy Fiddaman 2 months ago

I assume this is the same problem - with nss 3.68 I see:

/usr/include/mps/secmodt.h:79:5: error: unknown type name 'CK_NSS_GetFIPSStatus'
Actions #3

Updated by Andrew Stormont 2 months ago

It's been a while and the original build error has been lost to the sands of time, but I could probably reproduce it. I don't think that's it, however. Try the fix and see if it helps though.

Actions #4

Updated by Andrew Stormont about 2 months ago

There's a fix available here: https://code.illumos.org/c/illumos-gate/+/1591

I tested this with NSS 3.35 and NSS 3.57.

Actions #5

Updated by Andrew Stormont about 2 months ago

More testing notes:

This was tested by building illumos-gate against NSS 3.35 – which does not suffer from the issue described in this ticket – and NSS 3.57, which does. In both cases illumos-gate builds cleanly. We don’t use a package manager and build our OS from source every time, so we usually catch breakages in other components when touching illumos header files, but we haven’t seen any. We have been running the new NSS version for a while internally and plan to ship it in our next release.

Actions #6

Updated by Electric Monk about 1 month ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 99bbd8be9863c23df705ba5a97789ed021e4e3bd

commit  99bbd8be9863c23df705ba5a97789ed021e4e3bd
Author: Andrew Stormont <astormont@racktopsystems.com>
Date:   2021-08-13T14:22:12.000Z

    13930 Build fails with modern NSS
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF