Project

General

Profile

Actions

Bug #13941

open

intel code and headers should not look ia32 specific

Added by Rich Lowe 16 days ago. Updated 15 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

As an artifact of history, we have amd64 specific bits in sys/ia32/... headers, and sys/headers which include them. We should just put the headers straight into sys/ and leave symlinks, so as not to be confusing.
sys/ia32/ for headers that really are 32bit and shared with the 32bit userland (mostly register sets and layouts).

Actions #1

Updated by Rich Lowe 16 days ago

  • Subject changed from intel headers should be in sys/ not sys/ia32 unless they actually are ia32 specific to intel code and headers should not look ia32 specific
Actions #2

Updated by Electric Monk 15 days ago

  • Gerrit CR set to 1602
Actions #3

Updated by Patrick Mooney 15 days ago

I have some mixed feelings about this: Given how uts/intel is already home to dozens of directories meant only to house makefiles and build artifacts, I thought it was somewhat useful for the ISA-specific code to be grouped under ia32. This was especially true when I was less familiar with the codebase.

This does (IMO) come down to a matter of preference, so if the prevailing sentiment is in favor of the renames, I won't object.

Actions

Also available in: Atom PDF