Project

General

Profile

Actions

Bug #13942

closed

ksetpw salt may be used uninitialized

Added by C Fraire 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The root cause of the error that revealed #13935 is an uninitialized pointer that is used when no `-s salt_name` is specified. Notably, the uninitialized variable is not identified in #13790.

Current behavior with just #13935 :

/tmp/ksetpw: No such file or directory Could not retrieve entry in keytab
/tmp/ksetpw: Not enough space Could not compute salt for AES-256 CTS mode with 96-bit SHA-1 HMAC


Related issues

Related to illumos gate - Bug #13936: ksetpw typo to strtok_r() prevents space delimited -e enctype_listClosedC Fraire

Actions
Related to illumos gate - Bug #13935: ksetpw passes integers to %s format specifierClosedC Fraire

Actions
Actions #1

Updated by C Fraire 5 months ago

With the fix:

/tmp/ksetpw: No such file or directory Could not retrieve entry in keytab

Actions #2

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1597
Actions #3

Updated by C Fraire 5 months ago

Further test after using /tmp/ketpw to create a keytab to bind to Active Directory (redacted domain as example.com and also hosts):

# ldapsearch -h dc.example.com -o mech=gssapi -o authzid='' \
-b "cn=host1,cn=computers,dc=example,dc=com" -s base "" cn
version: 1
dn: cn=host1,cn=computers,dc=example,dc=com
cn: HOST1

Actions #4

Updated by Dan McDonald 4 months ago

  • Related to Bug #13936: ksetpw typo to strtok_r() prevents space delimited -e enctype_list added
Actions #5

Updated by Dan McDonald 4 months ago

  • Related to Bug #13935: ksetpw passes integers to %s format specifier added
Actions #6

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 298aa1575e761a7d02bc7c65fa603ffd0266fcb7

commit  298aa1575e761a7d02bc7c65fa603ffd0266fcb7
Author: Chris Fraire <cfraire@me.com>
Date:   2021-08-10T17:08:28.000Z

    13935 ksetpw passes integers to %s format specifier
    13936 ksetpw typo to strtok_r() prevents space delimited -e enctype_list
    13942 ksetpw salt may be used uninitialized
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF