Project

General

Profile

Actions

Bug #13944

closed

nsswitch getnetgrent.c build has reset CERRWARN and SMATCH

Added by Toomas Soome 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

ironically, this will enable some warnings on sparc and this breaking the build on sparc..

Errors are listed here:

2,3d1
<                  from ../common/files_common.h:38,
<                  from ../common/getnetgrent.c:46:
5,23d2
< ../common/files_common.h:67:7: note: 'fh_refcnt' declared here
< ../common/getnetgrent.c: In function '_nss_files_netgroup_constr':
< ../common/getnetgrent.c: In function 'getnetgr_destr':
< ../common/getnetgrent.c: In function 'getnetgr_end':
< ../common/getnetgrent.c: In function 'match_triple':
< ../common/getnetgrent.c: In function 'netgr_destr':
< ../common/getnetgrent.c: In function 'str2netgr':
< ../common/getnetgrent.c:151:34: warning: unused parameter 'lenstr' [-Wunused-parameter]
< ../common/getnetgrent.c:151:59: warning: unused parameter 'buffer' [-Wunused-parameter]
< ../common/getnetgrent.c:151:71: warning: unused parameter 'buflen' [-Wunused-parameter]
< ../common/getnetgrent.c:316:50: warning: unused parameter 'dummy' [-Wunused-parameter]
< ../common/getnetgrent.c:338:52: warning: unused parameter 'dummy' [-Wunused-parameter]
< ../common/getnetgrent.c:775:18: warning: comparison of integer expressions of different signedness: 'uint_t' {aka 'unsigned int'} and 'int' [-Wsign-compare]
< ../common/getnetgrent.c:780:9: warning: comparison of integer expressions of different signedness: 'uint_t' {aka 'unsigned int'} and 'int' [-Wsign-compare]
< ../common/getnetgrent.c:835:45: warning: unused parameter 'dummy' [-Wunused-parameter]
< ../common/getnetgrent.c:857:40: warning: unused parameter 'dummy1' [-Wunused-parameter]
< ../common/getnetgrent.c:857:60: warning: unused parameter 'dummy2' [-Wunused-parameter]
< ../common/getnetgrent.c:858:17: warning: unused parameter 'dummy3' [-Wunused-parameter]
< ../common/getnetgrent.c:99:1: warning: missing initializer for field 'fh_refcnt' of 'files_hash_t' [-Wmissing-field-initializers]
27,28d5
< In file included from ../common/getnetgrent.c:46:
< In file included from /code/illumos-gate/proto/root_sparc/usr/include/nss_dbdefs.h:46,

Testing done: build/install/boot.


Related issues

Related to illumos gate - Feature #3163: nss: need local netgroup implementationClosedAndy Fiddaman2021-06-17

Actions
Actions #1

Updated by Toomas Soome 5 months ago

  • Related to Feature #3163: nss: need local netgroup implementation added
Actions #2

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1603
Actions #3

Updated by Toomas Soome 5 months ago

  • Description updated (diff)
Actions #4

Updated by Toomas Soome 4 months ago

  • Description updated (diff)
Actions #5

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 85ee7b00732be2ebee41883d84ee6454eafcb8d4

commit  85ee7b00732be2ebee41883d84ee6454eafcb8d4
Author: Toomas Soome <tsoome@me.com>
Date:   2021-07-19T16:17:30.000Z

    13944 nsswitch getnetgrent.c build has reset CERRWARN and SMATCH
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Klaus Ziegler <klausz@haus-gisela.de>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF