Project

General

Profile

Bug #1396

dtrace iscsit.d missing int promotion for dlength

Added by Kris Shannon over 9 years ago. Updated over 9 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
comstar - iSCSI/FC/SAS target
Start date:
2011-08-21
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

The line
ii_datalen = P->dlength0 << 16 | P->dlength1 << 8 | P->dlength2;
is missing casts to uint32_t which means that ii_datalen = P->dlength2
which in most cases is zero.

Files

iscsit-dlength.diff (4.35 KB) iscsit-dlength.diff Kris Shannon, 2011-08-21 03:25 PM
#1

Updated by Kris Shannon over 9 years ago

This should fix it.

As an aside, this file exists on the installed system at /usr/lib/dtrace/iscsit.d but making this change to it doesn't seem to affect anything. Is a reboot necessary or is this actually cached/compiled somewhere else?

Also available in: Atom PDF