Project

General

Profile

Actions
Copy link

Bug #13965

closed

loader: open file list should be dynamic

Added by Toomas Soome 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Open file list is currently created as statically allocated array (64 items). Once this array is filled up, loader will not be able to operate with files. In most cases, this mechanism is good enough, but the problem appears, when we have many disks with zfs pool(s). In current loader implementation, all discovered zfs pool configurations are kept in memory and disk devices open - consuming the open file array. Rewrite the open file mechanism to use dynamically allocated list.

Testing done: build/install/boot, loader is working as expected.
Tested also with userboot module + libumem, this test did point to use TAILQ_FOREACH_REVERSE_SAFE.

Actions
Copy link
 #1

Updated by Toomas Soome 10 months ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk 9 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a2027c5d4c477546faea39a790b019c3480c9b9b

commit  a2027c5d4c477546faea39a790b019c3480c9b9b
Author: Toomas Soome <tsoome@me.com>
Date:   2021-08-20T17:04:44.000Z

    13965 loader: open file list should be dynamic
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF