Project

General

Profile

Actions
Copy link

Bug #13970

closed

loader: BIOS loader ld script needs to use KEEP statement with linker sets

Added by Toomas Soome 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The binutils 2.37 has introduced feature to produce "cleaner" binaries, unfortunately it also does affect our BIOS loader build. With current source, the linked ELF binary (loader.sym), has removed linker set functions, because those are not directly referenced. To fix, we need to tell ld to keep linker set symbols, https://wiki.osdev.org/Linker_Scripts#KEEP

Testing done: build with binutils 2.37, confirm the BIOS loader is functional.

Actions
Copy link
 #1

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6963446fe0c14e57937622dbef439717f823d078

commit  6963446fe0c14e57937622dbef439717f823d078
Author: Toomas Soome <tsoome@me.com>
Date:   2021-07-30T08:21:23.000Z

    13970 loader: BIOS loader ld script needs to use KEEP statement with linker sets
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Actions
Copy link

Also available in: Atom PDF