Project

General

Profile

Actions

Bug #14002

closed

Autogenerated dtrace.mapfile not cleaned up by clean nor clobber

Added by Thirteen Oxide 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Low
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Generated dtrace.mapfile output in several driver directories leaves their debug64 and/or obj64 directories lying around after a clobber. usr/src/uts/Makefile.mapfile could (and should!) append $(DTRACE_MAPFILE) to CLEANFILES to prevent this.


Related issues

Related to illumos gate - Feature #10362: Catch kernel module undefined symbols at build timeClosedRobert Mustacchi2019-02-09

Actions
Actions #1

Updated by Robert Mustacchi 4 months ago

  • Assignee set to Robert Mustacchi
Actions #2

Updated by Robert Mustacchi 4 months ago

  • Related to Feature #10362: Catch kernel module undefined symbols at build time added
Actions #3

Updated by Robert Mustacchi 4 months ago

  • Subject changed from mapfile turds not cleaned up by clean nor clobber to Autogenerated dtrace.mapfile not cleaned up by clean nor clobber
  • % Done changed from 0 to 60
Actions #4

Updated by Robert Mustacchi 4 months ago

To test this I went and manually ran dmake clean and verified that the auto-generated dtrace.mapfile was removed. I also remade it and made sure, as expected, it was removed with dmake clobber. In addition I ran two different wsdiffs comparing the results of this change with the same worskpace without it. And then two builds in a row here and verified that the only thing that changed was the etc/versions/build file across the first wsdiff. The second one was empty.

Actions #5

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 60 to 100

git commit 12b9cfba7240ddd84e8bdba67d8df9c0bf9ffb76

commit  12b9cfba7240ddd84e8bdba67d8df9c0bf9ffb76
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-08-10T23:02:41.000Z

    14002 Autogenerated dtrace.mapfile not cleaned up by clean nor clobber
    Reviewed by: Rich Lowe <richlowe@richlowe.net>
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions

Also available in: Atom PDF