Autogenerated dtrace.mapfile not cleaned up by clean nor clobber
Generated dtrace.mapfile output in several driver directories leaves their debug64 and/or obj64 directories lying around after a clobber. usr/src/uts/Makefile.mapfile could (and should!) append $(DTRACE_MAPFILE) to CLEANFILES to prevent this.
Updated by Robert Mustacchi 4 months ago
To test this I went and manually ran
dmake clean and verified that the auto-generated dtrace.mapfile was removed. I also remade it and made sure, as expected, it was removed with
dmake clobber. In addition I ran two different wsdiffs comparing the results of this change with the same worskpace without it. And then two builds in a row here and verified that the only thing that changed was the
etc/versions/build file across the first wsdiff. The second one was empty.
Updated by Electric Monk 4 months ago
- Status changed from New to Closed
- % Done changed from 60 to 100
commit 12b9cfba7240ddd84e8bdba67d8df9c0bf9ffb76 Author: Robert Mustacchi <email@example.com> Date: 2021-08-10T23:02:41.000Z 14002 Autogenerated dtrace.mapfile not cleaned up by clean nor clobber Reviewed by: Rich Lowe <firstname.lastname@example.org> Reviewed by: Dan Cross <email@example.com> Reviewed by: Andy Fiddaman <firstname.lastname@example.org> Approved by: Garrett D'Amore <email@example.com>