Project

General

Profile

Actions

Bug #14036

closed

pxeboot: improve and simplify rx handling

Added by Toomas Soome 3 months ago. Updated 25 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Picked up patch from FreeBSD:

Author: Kyle Evans <>
Date: Wed Aug 11 21:49:17 2021 -0500

pxeboot: improve and simplify rx handling
Reviewed by: Toomas Soome &lt;&gt;
This pushes the bulk of the rx servicing into a single loop that's only
slightly convoluted, and it addresses a problem with rx handling in the
process. If we hit a tx interrupt while we're processing, we'd
previously drop the frame on the floor completely and ultimately
timeout, increasing boot time on particularly busy hosts as we keep
having to backoff and resend.
After this patch, we don't seem to hit timeouts at all on zoo anymore
though loading a 27M kernel is still relatively slow (~1m20s).
Triage by:      Ash Gokhale &lt;ashfixit gmail com&gt;
Differential Revision: https://reviews.freebsd.org/D31512

Also tested by Andy Fiddaman and myself (that is, on illumos based systems).

Actions #1

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 1681
Actions #2

Updated by Toomas Soome 26 days ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 25 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 99e6398ed34e1943640f382fec1971ba1ecc2f99

commit  99e6398ed34e1943640f382fec1971ba1ecc2f99
Author: Kyle Evans <kevans@FreeBSD.org>
Date:   2021-11-03T08:35:20.000Z

    14036 pxeboot: improve and simplify rx handling
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF