Project

General

Profile

Actions
Copy link

Bug #14070

closed

vntsd: cast between incompatible function types

Added by Toomas Soome about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1702
External Bug:

Description

Build errors on SPARC:

    vntsd.c: In function 'vntsd_reset_timer':
    vntsd.c:174:38: error: cast between incompatible function types from 'boolean_t (*)(vntsd_timeout_t *, thread_t)' {aka 'boolean_t (*)(struct vntsd_timeout *, unsigned int)'} to 'int (*)(void *, void *)' [-Werror=cast-function-type]
      174 |  (void) vntsd_que_find(vntsdp->tmoq, (compare_func_t)reset_timeout,
          |                                      ^
    cc1: all warnings being treated as errors

    cmd.c:253:35: error: cast between incompatible function types from 'int (*)(void)' to 'int (*)(vntsd_client_t *)' {aka 'int (*)(struct vntsd_client *)'} [-Werror=cast-function-type]
      253 |  {'.', "Exit from this console",  (e_func_t)client_exit},
          |                                   ^
    cc1: all warnings being treated as errors

Fix function signature.

Testing done: build/install/boot.

Actions
Copy link
 #1

Updated by Electric Monk about 1 year ago

  • Gerrit CR set to 1702
Actions
Copy link
 #2

Updated by Electric Monk 12 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f8871fbc1b7e2d91a441e896a3436e6a76f21bc0

commit  f8871fbc1b7e2d91a441e896a3436e6a76f21bc0
Author: Toomas Soome <tsoome@me.com>
Date:   2021-10-19T06:06:36.000Z

    14070 vntsd: cast between incompatible function types
    Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org>
    Reviewed by: Klaus Ziegler <klausz@haus-gisela.de>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF