Project

General

Profile

Actions
Copy link

Bug #14080

closed

cw does not honor dmake silent flag

Added by Ryan Goodfellow 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Low
Assignee:
Ryan Goodfellow
Category:
tools - gate/build tools
Start date:
2021-09-15
Due date:
% Done:

100%

Estimated time:
1.00 h
Difficulty:
Bite-size
Tags:
cw dmake
Gerrit CR:

Description

When compiling illumos with the silent flag (dmake -s), any command that goes through cw gets echoed anyway. This is because cw is not set up to detect the -s flag from dmake, even though it is available in the MAKEFLAGS environment variable.

Actions
Copy link
 #1

Updated by Ryan Goodfellow 8 months ago

I have tested the following patch now up for review.

- https://code.illumos.org/c/illumos-gate/+/1708/1/usr/src/tools/cw/cw.c

It has the desired effect of not echoing delegated commands from cw when dmake is invoked with the -s flag.

I've also performed a full nightly build successfully.

Actions
Copy link
 #2

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit c3d5f7c437ff92ea7e52cd66a2b9b892f58d46b0

commit  c3d5f7c437ff92ea7e52cd66a2b9b892f58d46b0
Author: Ryan Goodfellow <ryan.goodfellow@oxide.computer>
Date:   2021-09-21T19:09:45.000Z

    14080 cw does not honor dmake silent flag
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF