Project

General

Profile

Actions

Bug #14085

closed

ASSERT failure in smb_sd_tofs

Added by Gordon Ross 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

ASSERT tripped in smb_sd_tofs when running smbtorture smb2.create.nulldacl

Stack trace like this:

smb_sd_tofs+0x1ac(fc8d6dcc, fc8d6d78)
smb_sd_write+0x4a(829a008, fc8d6dcc, 4)
smb2_setinfo_sec+0xe7(829a008, fc8d6e34, 4)
smb2_set_info+0x208(829a008)
smb2sr_work+0x68d(829a008)
smb2_tq_work+0x76(829a008)
taskq_thread+0xc2(816ee18)

Actions #1

Updated by Gordon Ross 8 months ago

Note, in the PR we're taking just the ASSERT fix, from nexenta@7f3a6fbbb2519d7adc6a4baf8321aad811a950af
leaving the rest of the fix for SMB "create with SD with NULL DACL" for later, because that depends on some things not yet upstream.

Actions #2

Updated by Gordon Ross 8 months ago

Testing: re-run smbtorture ... smb2.create.nulldacl. (no panic)

Actions #3

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 3ef858b31c01b625ea69d415521ccf427333f52d

commit  3ef858b31c01b625ea69d415521ccf427333f52d
Author: Matt Barden <mbarden@tintri.com>
Date:   2021-09-17T20:28:38.000Z

    14085 ASSERT failure in smb_sd_tofs
    Reviewed by: Gordon Ross <gordon.ross@tintri.com>
    Reviewed by: Prashanth Badari <prbadari@tintri.com>
    Reviewed by: Jason King <jason.brian.king@gmail.com>

Actions #4

Updated by Gordon Ross 8 months ago

Approved by: Richard Lowe <>

Sorry I forgot to add that before I pushed.

Actions

Also available in: Atom PDF