Project

General

Profile

Actions

Feature #14092

closed

imc(7D) should not be under i86pc

Added by Robert Mustacchi 4 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

When I originally integrated the imc driver, I put it under uts/i86pc in part of trying to avoid issues with whether or not it'd exist on xpv. However, because of how it works, a psuedo-device driver and a bunch of things that bind to PCI IDs, it really isn't specific to i86pc and should actually really have been in uts/intel as there's nothing specific there. As such, we should move it to the right place.

To test this I went back and run the full regression test suite for imc and verified that everything still passes.

Actions #1

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 1716
Actions #2

Updated by Robert Mustacchi about 2 months ago

As an additional test, Patrick booted this on an Ivy Bridge system and we verified that the driver attached correctly and the topo enumeration hadn't changed.

Actions #3

Updated by Electric Monk about 2 months ago

  • Status changed from New to Closed
  • % Done changed from 30 to 100

git commit 74079a53e205d2eeb75b215833ddc684a1db3088

commit  74079a53e205d2eeb75b215833ddc684a1db3088
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-12-03T20:01:18.000Z

    14092 imc(7D) should not be under i86pc
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF