Project

General

Profile

Actions

Feature #14096

open

SMB should export a header for kstats

Added by Gordon Ross 8 months ago. Updated 8 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The SMB server has some useful statistics, normally shown by the smbstat command, that external software may want to consume.
(I know of a couple appliance management applications that use this.)

To facilitate this, the SMB server should provide a header that defines the structures presented in those kstats,
without requiring the consuming application to import all of the internal smbsrv headers.

Import this change from github/Nexenta

commit 389c05851d2b6c65da9ac6399a345a3e2c3236d0
Author: Gordon Ross <gwr@nexenta.com>
Date:   Fri Nov 13 13:53:20 2015 -0500

    NEX-4811 SMB needs to export a header for kstats
    Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
    Reviewed by: Jeffry Molanus <jeffry.molanus@nexenta.com>

12      10      usr/src/cmd/smbsrv/smbstat/smbstat.c
6       0       usr/src/uts/common/fs/smbsrv/smb_server.c
13      5       usr/src/uts/common/smbsrv/smb_kstat.h

Perhaps "export" in the subject is over stating what this change does.
The header is still not packaged, but allows a consumer to use it
without the need to pull in the rest of the smbsrv headers.
This change would allow packaging that header, but that was not
requested and not implemented here.

Actions #1

Updated by Gordon Ross 8 months ago

  • Tracker changed from Bug to Feature
Actions #2

Updated by Gordon Ross 8 months ago

  • Description updated (diff)
Actions #3

Updated by Gordon Ross 8 months ago

  • Description updated (diff)
Actions #4

Updated by Electric Monk 8 months ago

  • Gerrit CR set to 1720
Actions

Also available in: Atom PDF