Project

General

Profile

Actions

Bug #14121

closed

loader: net_open() should not replace f->f_devdata

Added by Toomas Soome 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

net_open() does replace f_devdata with pointer to netdev_sock, this will cause memory leak when device is closed, but also does alter the devopen() logic.

We should store &netdev_sock to dev->d_opendata instead, this would preserve and follow the devopen() logic.

Testing done: build/install/boot /network boot.

Actions #1

Updated by Electric Monk 8 months ago

  • Gerrit CR set to 1734
Actions #2

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6538c7b4c76e1d53fc801540cfe1dfe59d26bf29

commit  6538c7b4c76e1d53fc801540cfe1dfe59d26bf29
Author: Toomas Soome <tsoome@me.com>
Date:   2021-11-05T16:10:47.000Z

    14121 loader: net_open() should not replace f->f_devdata
    Reviewed by: Klaus Ziegler <klausz@haus-gisela.de>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF