Project

General

Profile

Actions
Copy link

Bug #14146

closed

sgs/prof: multiply-defined symbols

Added by Yuri Pankov about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Yuri Pankov
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1744

Description

Build errors with gcc10:

ld: fatal: symbol 'debug_value' is multiply-defined:
        (file prof.o type=OBJT; file symintOpen.o type=OBJT);
ld: fatal: symbol 'debug_value' is multiply-defined:
        (file prof.o type=OBJT; file symintClose.o type=OBJT);
ld: fatal: symbol 'debug_value' is multiply-defined:
        (file prof.o type=OBJT; file symintUtil.o type=OBJT);
ld: fatal: symbol 'debug_value' is multiply-defined:
        (file prof.o type=OBJT; file symintLoad.o type=OBJT);
ld: fatal: file processing errors. No output written to prof

To test this, I simply ran the resulting prof binary (it runs) -- all uses of debug_value are hidden under OLD_DEBUG() (the fix does the same for debug_value). More so, after uncommenting OLD_DEBUG (i.e. #define OLD_DEBUG(x) x) build fails because of the other issues unrelated to debug_value (probably the code is showing its age).

Files

prof.txt (208 KB) prof.txt disassembly diff Yuri Pankov, 2021-10-12 02:49 PM
Actions
Copy link
 #1

Updated by Electric Monk about 2 months ago

  • Gerrit CR set to 1744
Actions
Copy link
 #2

Updated by Yuri Pankov about 2 months ago

  • Status changed from New to In Progress
  • Assignee set to Yuri Pankov
  • % Done changed from 0 to 10
  • Difficulty changed from Medium to Bite-size
Actions
Copy link
 #3

Updated by Yuri Pankov about 2 months ago

  • Description updated (diff)
  • Status changed from In Progress to Pending RTI
  • % Done changed from 10 to 90
Actions
Copy link
 #4

Updated by Yuri Pankov about 2 months ago

Actions
Copy link
 #5

Updated by Electric Monk about 1 month ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 22af455af0d6d6c5720f009255b3ac2e18f5bcc9

commit  22af455af0d6d6c5720f009255b3ac2e18f5bcc9
Author: Yuri Pankov <ypankov@tintri.com>
Date:   2021-10-12T14:59:06.000Z

    14146 sgs/prof: multiply-defined symbols
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF