Actions
Bug #14163
closedzfs-tests: remove_raidz.ksh is broken
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
remove_raidz can fail:
Test: /opt/zfs-tests/tests/functional/removal/remove_raidz (run as root) [03:42] [FAIL] 02:04:34.14 SUCCESS: mkfile 268435456 /tmp/dsk1 02:04:34.28 SUCCESS: mkfile 268435456 /tmp/dsk2 02:04:34.40 SUCCESS: mkfile 268435456 /tmp/dsk3 02:04:34.49 SUCCESS: zpool create -f testpool /tmp/dsk1 raidz /tmp/dsk2 /tmp/dsk3 02:04:34.52 SUCCESS: zfs create testpool/testfs 02:04:34.56 SUCCESS: zfs set mountpoint=/var/tmp/testdir testpool/testfs 02:04:34.57 SUCCESS: default_setup_noexit /tmp/dsk1 raidz /tmp/dsk2 /tmp/dsk3 02:04:34.57 SUCCESS: zpool remove testpool /tmp/dsk1 exited 1 02:04:34.58 SUCCESS: zpool remove testpool /tmp/dsk2 exited 1 02:04:34.59 SUCCESS: zpool remove testpool raidz1-1 exited 1 02:04:34.59 NOTE: Performing local cleanup via log_onexit (cleanup) 02:08:16.86 SUCCESS: rm -rf /var/tmp/testdir 02:08:16.92 rm: raidz is a directory 02:08:16.92 ERROR: rm -f /tmp/dsk1 raidz /tmp/dsk2 /tmp/dsk3 exited 2
So the fix is to move "raidz" out of disks list.
Test: /opt/zfs-tests/tests/functional/removal/remove_raidz (run as root) [03:51] [PASS] 10:23:41.17 SUCCESS: mkfile 268435456 /tmp/dsk1 10:23:41.31 SUCCESS: mkfile 268435456 /tmp/dsk2 10:23:41.45 SUCCESS: mkfile 268435456 /tmp/dsk3 10:23:41.73 SUCCESS: zpool create -f testpool /tmp/dsk1 raidz /tmp/dsk2 /tmp/dsk3 10:23:41.75 SUCCESS: zfs create testpool/testfs 10:23:41.80 SUCCESS: zfs set mountpoint=/var/tmp/testdir testpool/testfs 10:23:41.80 SUCCESS: default_setup_noexit /tmp/dsk1 raidz /tmp/dsk2 /tmp/dsk3 10:23:41.81 SUCCESS: zpool remove testpool /tmp/dsk1 exited 1 10:23:41.82 SUCCESS: zpool remove testpool /tmp/dsk2 exited 1 10:23:41.83 SUCCESS: zpool remove testpool raidz1-1 exited 1 10:23:41.83 NOTE: Performing local cleanup via log_onexit (cleanup) 10:27:32.83 SUCCESS: rm -rf /var/tmp/testdir 10:27:32.93 SUCCESS: rm -f /tmp/dsk1 /tmp/dsk2 /tmp/dsk3 10:27:32.93 Removal will not succeed if there is a top level mirror. Test: /opt/zfs-tests/tests/functional/removal/cleanup (run as root) [00:00] [PASS]
Updated by Electric Monk about 2 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit ba5494d78f75a2e62b09b817fc6abf7351a952c2
commit ba5494d78f75a2e62b09b817fc6abf7351a952c2 Author: Toomas Soome <tsoome@me.com> Date: 2021-10-23T21:24:47.000Z 14163 zfs-tests: remove_raidz.ksh is broken Reviewed by: Andy Fiddaman <andy@omnios.org> Approved by: Robert Mustacchi <rm@fingolfin.org>
Actions