Project

General

Profile

Actions

Bug #14165

closed

zpool man page needs to document implicit checkpoint discard

Added by Brian Bennett about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

https://github.com/openzfs/zfs/issues/12646

In short, rewinding to a checkpoint silently discards the checkpoint. A user that wants to take multiple tries at a potentially destructive action could incur severe data loss after the first checkpoint rewind because they expect the checkpoint to stick around after rewinding.

I ran into this, but I was lucky enough that I was working on an unrelated feature so the only thing I've lost is the time to install from scratch and get back to where I was at.

I think this is important enough to fix in gate ahead of whatever OpenZFS may do, and then we can adopt their version whenever it makes its way into gate.

Actions #1

Updated by Electric Monk about 1 month ago

  • Gerrit CR set to 1758
Actions #2

Updated by Brian Bennett about 1 month ago

Previewed changes using man. Everything looks like I expect it to.

Actions #3

Updated by Electric Monk about 1 month ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 0f2a8434f3b6c1825df77e8037c61c0f6fb6b300

commit  0f2a8434f3b6c1825df77e8037c61c0f6fb6b300
Author: Brian Bennett <brian.bennett@joyent.com>
Date:   2021-10-19T21:04:30.000Z

    14165 zpool man page needs to document implicit checkpoint discard
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF